c# - Can this "assignment in conditional expression" be removed without changing behavior? -



c# - Can this "assignment in conditional expression" be removed without changing behavior? -

refactoring legacy app, resharper flagged odd code:

if( retval = util.netsendcommand( returnedcommands.command ) )

the "retval = " part grayed out; assume can remove it. perhaps person wrote code meant equality test, working intended as-is, can safely remove "retval =" correct?

update

here's code in context:

public bool pendingcommandsexecute_ccrcommand() { bool retval = false; string themessage = new string( '\x00', 1023 ); string command = "ccrcommand"; seek { if (returnedcommands.key != command) homecoming false; hashresultsadd(command, "started"); if( retval = util.netsendcommand( returnedcommands.command ) ) { util.readfinishedchanged += new util.readfinishedhandler( readfinished_hhtcommand ); } else { homecoming false; // commandfailed // ( command // , ": not finish server handshaking \n" // + "failure - ccrcommand!" // ); } } grab (exception ex) { pdaclient.nrbq.exceptionhandler(ex, "pendingcommands.pendingcommandsexecute.hhtcommand"); homecoming false; } homecoming true; }

don't remove it. calling method, doesn't utilize value returns.

c# refactoring resharper equality assignment-operator

Comments

Post a Comment

Popular posts from this blog

php - Android app custom user registration and login with cookie using facebook sdk -

php - Android app custom user registration and login with cookie using facebook sdk - i developing android application in users need register , log in using facebook. approximately, flow. open app first time, authenticate facebook, data, send info server create them business relationship in application, start session new business relationship in server, cookie perform later interactions. so far good. what need know wich info have send server, can able identify users when log in seccond time. because need start session in server , send cookie android app farther interactions. i'm using php server side language. i thinking getting getaccesstoken() in android facebook sdk, pass server on business relationship creation , storing in android app. but can't manage how login users on sec time utilize app. any suggestions ? in advance ! to uniquely identify user within app, should create request /me , user's id. guaranteed unique , remain con
Read more

django - Access session in user model .save() -

django - Access session in user model .save() - is possible access current session in user model .save()? pseudo code of want achieve: # users.models.py def save(self, *args, **kwargs): created = true if self.pk: created = false super(abstractuser, self).save(*args, **kwargs) # post-save if created: look_for_invite_in_session_and_register_if_found(self, session) seems wrong in architecture. shouldn't access request in models layer. work request must done in view. can this: user, created = abstractuser.objects.get_or_create(name=name) if created: look_for_invite_in_session_and_register_if_found(user, request.session) django session
Read more

php - .htaccess Multiple Rewrite Rules / Prioritizing -

php - .htaccess Multiple Rewrite Rules / Prioritizing - here current htaccess file: rewriteengine on rewritecond %{http_host} !^www\.website\.com [nc] rewritecond %{http_host} ([^.]+)\.website\.com [nc] rewriterule ^(.*)$ http://www.website.com/gotourl.php?urlid=?%1 [l] rewriterule ^(\w+)$ ./gotourl.php?urlid=$1 [nc,l] rewriterule ^(\w+)/$ ./gotourl.php?urlid=$1 [nc,l] the website in question url shortener i'm working on testing/developing , personal use. above code may not ideal i'm not familiar .htaccess , made via googling , testing. want url shortening aspect: http://website.com/1234 -> http://website.com/gotourl.php?urlid=1234 http://website.com/1234/ -> http://website.com/gotourl.php?urlid=1234 the problem cannot figure out how ignore directories. want specific directories go specific pages: http://website.com/img (or) http://website.com/img/ -> http://website.com/img.php http://website.com/img/1234 (or) http://website.com/
Read more