ruby - Understanding Rubocop "code unreachable" cop -



ruby - Understanding Rubocop "code unreachable" cop -

i have next statement

if !defined?(proxy) || proxy.blank?

and trying accomplish avoiding undefined methods on nil object. intention

check if "proxy" object defined begin with check if "proxy" object not blank (but otherwise defined)

rubocop says "unreachable code detected" but, read it, object "proxy" can defined empty means sec part of if statement evaluated.

how code unreachable?

edit based on our discussion in chat:

defined? not right approach, check whether variable not defined, not value is. operates on meta-level, speak. think of defined? keyword answering question "was thing declared anywhere in code before?".

normally, check nil value using object#nil? method. way inquire question "is variable empty?". code declares proxy variable in case, reason why code within if-statement unreachable: proxy never undefined.

you can write

if proxy.nil? || proxy.blank? # ... end

ruby rubocop

Comments

Post a Comment

Popular posts from this blog

model view controller - MVC Rails Planning -

model view controller - MVC Rails Planning - i'm starting rails , i'm building app stores films info, user can watch film , give grade on web application. i have coded cinema model, controller , views. now, have 2 questions: should need create model , controller grading? in case, should create or should wait , create first users model , controller? yes, on model , controller grades. that'd feasible way maintain track of who's graded what. it's create first, i'd start users, since grades depend on both films , users. ruby-on-rails model-view-controller
Read more

ruby on rails - Devise Logout Error in RoR -

ruby on rails - Devise Logout Error in RoR - while using devise in ror, encountering unusual error when trying log out url different root url. displays me : actioncontroller::invalidauthenticitytoken in devise::sessionscontroller#destroy" for illustration if rooting path after log in '/structure', , seek log out '/general' error, while logging out '/structure' fine. any help highly appreciated. ruby-on-rails ruby devise
Read more

html - Submenu setup with jquery and effect 'fold' -

html - Submenu setup with jquery and effect 'fold' - i want open submenu jquery effect fold, problem if user "hover effect" fast menu remain open, how can avoid this, jquery code is: $('ul.mainmenu li').hover( function() { $(this).children('ul').show('fold', 570); }, function() { $(this).children('ul').hide('fold', 500); } ); my jsfiddle link is: http://jsfiddle.net/9wkbf/ updated fiddle the reason behind problem is, first event $(this).children('ul').show('fold', 570); queued , until completes, sec animation not start. the next snippet can workaround $('ul.mainmenu > li').hover( function() { $(this).children('ul').show('fold', 570); }, function() { $('ul:not(.mainmenu)').hide('fold', 500); } ); *important note : work current scenario. jquery html css
Read more